Modernize exception handling for devteam tools #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Jan 8, 2021
nsoranzo
reviewed
Jan 8, 2021
|
The tests have not been running here :( |
|
@bgruening not surprising, I just checked, and all of them are in |
|
I'm a little bit hesitant to merge this without tests, but if we enable tests we probably get a lot of linting and testing issues. |
|
It might be interesting to see how many errors we get? I know that anything depending on package_taxonomy will fail, because the bitbucket URL to download that tarball is now 404. |
nsoranzo
reviewed
Jan 8, 2021
|
This needs some more work before it can be merged. |
|
@davebx are you working on that still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also gets rid of
tool_dependencies.xmlfor those tools.